Skip to content

Commit

Permalink
Update rubocop requirement from 1.11.0 to 1.12.0 (#228)
Browse files Browse the repository at this point in the history
* Update rubocop requirement from 1.11.0 to 1.12.0

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.11.0...v1.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update .rubocop_todo.yml

* [RSpec/RepeatedDescription] Don't repeat descriptions within an example group

As there was a typo in a spec title

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Santiago Traversa <santiago.traversa@gmail.com>
  • Loading branch information
dependabot-preview[bot] and san983 committed Mar 29, 2021
1 parent 3de5140 commit 5e4e954
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
14 changes: 2 additions & 12 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-02-11 05:02:06 UTC using RuboCop version 1.9.1.
# on 2021-03-29 11:48:18 UTC using RuboCop version 1.12.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Cop supports --auto-correct.
Lint/RedundantDirGlobSort:
Exclude:
- 'spec/spec_helper.rb'

# Offense count: 6
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
Expand Down Expand Up @@ -45,11 +39,6 @@ RSpec/MultipleExpectations:
RSpec/NamedSubject:
Enabled: false

# Offense count: 2
RSpec/RepeatedDescription:
Exclude:
- 'spec/dnsimple/client/zones_spec.rb'

# Offense count: 10
RSpec/StubbedMock:
Exclude:
Expand Down Expand Up @@ -78,5 +67,6 @@ RSpec/VerifiedDoubles:
- 'spec/dnsimple/client_spec.rb'

# Offense count: 39
# Configuration parameters: AllowedConstants.
Style/Documentation:
Enabled: false
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ source 'https://rubygems.org'
gemspec

gem 'coveralls', require: false
gem 'rubocop', '1.11.0', require: false
gem 'rubocop', '1.12.0', require: false
gem 'rubocop-performance', require: false
gem 'rubocop-rake', require: false
gem 'rubocop-rspec', require: false
2 changes: 1 addition & 1 deletion spec/dnsimple/client/zones_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&sort=name:desc")
end

it "supports sorting" do
it "supports filtering" do
subject.all_zones(account_id, filter: { name_like: "zone.test" })

expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&name_like=zone.test")
Expand Down

0 comments on commit 5e4e954

Please sign in to comment.