Create record validates mandatory attribute presence

dnsimple · May 5, 2016 · 8600d7e · 8600d7e
1 parent 0b1343d
commit 8600d7e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/dnsimple/client/templates_records.rb b/lib/dnsimple/client/templates_records.rb
@@ -66,6 +66,7 @@ def all_records(account_id, template_id, options = {})
       #
       # @raise  [Dnsimple::RequestError]
       def create_record(account_id, template_id, attributes, options = {})
+        Extra.validate_mandatory_attributes(attributes, [:type, :name, :content])
         endpoint = Client.versioned("/%s/templates/%s/records" % [account_id, template_id])
         response = client.post(endpoint, attributes, options)
 

diff --git a/spec/dnsimple/client/templates_records_spec.rb b/spec/dnsimple/client/templates_records_spec.rb
@@ -81,6 +81,26 @@
       expect(result.updated_at).to eq("2016-05-03T07:51:33.202Z")
     end
 
+    context "with missing data" do
+      it "raises an error when the type is missing" do
+        expect {
+          subject.create_record(account_id, template_id, name: "", content: "192.168.1.1")
+        }.to raise_error(ArgumentError)
+      end
+
+      it "raises an error when the name is missing" do
+        expect {
+          subject.create_record(account_id, template_id, type: "A", content: "192.168.1.1")
+        }.to raise_error(ArgumentError)
+      end
+
+      it "raises an error when the content is missing" do
+        expect {
+          subject.create_record(account_id, template_id, type: "A", name: "")
+        }.to raise_error(ArgumentError)
+      end
+    end
+
     context "when the template does not exist" do
       it "raises NotFoundError" do
         stub_request(:post, %r{/v2}).