[Corrected] RSpec/IteratedExpectation

Prefer using the all matcher instead of iterating over an array
dnsimple · Dec 10, 2020 · 937fd76 · 937fd76
1 parent f363936
commit 937fd76
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -19,12 +19,6 @@ RSpec/ContextWording:
 RSpec/ExampleLength:
   Enabled: false
 
-# Offense count: 2
-RSpec/IteratedExpectation:
-  Exclude:
-    - 'spec/dnsimple/client/services_domains_spec.rb'
-    - 'spec/dnsimple/client/services_spec.rb'
-
 # Offense count: 1
 RSpec/LeakyConstantDeclaration:
   Exclude:

diff --git a/spec/dnsimple/client/services_domains_spec.rb b/spec/dnsimple/client/services_domains_spec.rb
@@ -52,9 +52,7 @@
         expect(service.sid).to be_a(String)
         expect(service.description).to be_a(String)
 
-        service.settings.each do |service_setting|
-          expect(service_setting).to be_a(Dnsimple::Struct::Service::Setting)
-        end
+        expect(service.settings).to all(be_a(Dnsimple::Struct::Service::Setting))
       end
     end
   end

diff --git a/spec/dnsimple/client/services_spec.rb b/spec/dnsimple/client/services_spec.rb
@@ -49,9 +49,7 @@
         expect(service.sid).to be_a(String)
         expect(service.description).to be_a(String)
 
-        service.settings.each do |service_setting|
-          expect(service_setting).to be_a(Dnsimple::Struct::Service::Setting)
-        end
+        expect(service.settings).to all(be_a(Dnsimple::Struct::Service::Setting))
       end
     end
   end