Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rubocop to version 0.80.1 #174

Merged
merged 8 commits into from
Mar 19, 2020
Merged

Upgrade rubocop to version 0.80.1 #174

merged 8 commits into from
Mar 19, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 1, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.79.0 → 0.80.1) · Repo · Changelog

Release Notes

0.80.1

Bug fixes

  • #7719: Fix Style/NestedParenthesizedCalls cop for newline. (@tejasbubane)
  • #7709: Fix correction of Style/RedundantCondition when the else branch contains a range. (@rrosenblum)
  • #7682: Fix Style/InverseMethods autofix leaving parenthesis. (@tejasbubane)
  • #7745: Suppress a pending cop warnings when pending cop's department is disabled. (@koic)
  • #7759: Fix an error for Layout/LineLength cop when using lambda syntax that argument is not enclosed in parentheses. (@koic)

Changes

  • #7765: When warning about a pending cop, display the version with the cop added. (@koic)

0.80.0

New features

  • #7693: NodePattern: Add ` for descendant search. (@marcandre)
  • #7577: Add AllowGemfileRubyComment configuration on Layout/LeadingCommentSpace. (@cetinajero)
  • #7663: Add new Style/HashTransformKeys and Style/HashTransformValues cops. (@djudd, @eugeneius)
  • #7619: Support autocorrect of legacy cop names for Migration/DepartmentName. (@koic)
  • #7659: Layout/LineLength autocorrect now breaks up long lines with blocks. (@maxh)
  • #7677: Add a cop for Hash#each_key and Hash#each_value. (@jemmaissroff)
  • Add BracesRequiredMethods parameter to Style/BlockDelimiters to require braces for specific methods such as Sorbet's sig. (@maxh)
  • #7686: Add new JUnitFormatter formatter based on rubocop-junit-formatter gem. (@koic)
  • #7715: Add Steepfile to default Include list. (@ybiquitous)

Bug fixes

  • #7644: Fix patterns with named wildcards in unions. (@marcandre)
  • #7639: Fix logical operator edge case in omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #7661: Fix to return correct info from multi-line regexp. (@Tietew)
  • #7655: Fix an error when processing a regexp with a line break at the start of capture parenthesis. (@koic)
  • #7647: Fix an undefined method on_numblock error when using Ruby 2.7's numbered parameters. (@hanachin)
  • #7675: Fix a false negative for Layout/SpaceBeforeFirstArg when a vertical argument positions are aligned. (@koic)
  • #7688: Fix a bug in Style/MethodCallWithArgsParentheses that made --auto-gen-config crash. (@buehmann)
  • #7203: Fix an infinite loop error for Style/TernaryParentheses with Style/RedundantParentheses when using EnforcedStyle: require_parentheses_when_complex. (@koic)
  • #7708: Make it possible to use EOL rubocop:disable comments on comment lines. (@jonas054)
  • #7712: Fix an incorrect autocorrect for Style/OrAssignment when using elsif branch. (@koic)

Changes

  • #7636: Remove console from Lint/Debugger to prevent false positives. (@gsamokovarov)
  • #7641: (Breaking) Remove Style/BracesAroundHashParameters cop. (@pocke)
  • Add the method name to highlight area of Layout/EmptyLineBetweenDefs to help provide more context. (@rrosenblum)
  • #7652: Allow pp to allowed names of Naming/MethodParameterName cop in default config. (@masarakki)
  • #7309: Mark Lint/UselessSetterCall an "not safe" and improve documentation. (@jonas054)
  • #7723: Enable Migration/DepartmentName cop by default. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file. task labels Mar 1, 2020
@san983
Removes deleted cop Style/BracesAroundHashParameters
8273424 
rubocop/rubocop#7641
@san983
Added new cops from 0.80
62aad4b 
- Style/HashEachMethods
- Style/HashTransformKeys
- Style/HashTransformValues
@san983
Renames setttings array called "keys" to "settings"
187923c 
Due to a warning Style/HashEachMethods I realised that the "keys" was not the best one, I think it's best to call it "settings"
@san983
Adds "rubocop-performance" gem
61b08d1
@san983 san983 self-assigned this Mar 15, 2020
@san983 san983 requested review from weppos and jacegu March 16, 2020 19:26
@san983 san983 added the ready-for-review Pull requests that are ready to be reviewed by other team members. label Mar 16, 2020
weppos
weppos reviewed Mar 17, 2020
View reviewed changes
.rubocop.yml Show resolved Hide resolved
weppos
weppos reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

lib/dnsimple/default.rb Outdated Show resolved Hide resolved
@san983 san983 merged commit 48ff022 into master Mar 19, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.80.1 branch March 19, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@san983 san983 san983 left review comments

@weppos weppos weppos approved these changes

@jacegu jacegu jacegu approved these changes

Assignees

@san983 san983

Labels
dependencies Pull requests that update a dependency file. ready-for-review Pull requests that are ready to be reviewed by other team members. task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weppos @jacegu @san983