Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.0 and ruby-head to Travis #225

Merged
merged 8 commits into from Feb 12, 2021

Conversation

san983
Copy link
Member

@san983 san983 commented Feb 11, 2021

This PR:

  • Adds Ruby 3.0 and ruby-head to Travis allowing this last one to fail.
  • Cleans up Travis config
  • Removes ASDF versioning

We probably want to to cut a minor release after this one

@san983 san983 added enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. labels Feb 11, 2021
@san983 san983 self-assigned this Feb 11, 2021
@san983 san983 requested a review from weppos February 11, 2021 12:59
@san983 san983 marked this pull request as ready for review February 11, 2021 12:59
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Cop supports --auto-correct.
Lint/RedundantDirGlobSort:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant 😂

README.md Show resolved Hide resolved
Copy link
Contributor

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@san983 san983 merged commit d4538a8 into main Feb 12, 2021
@san983 san983 deleted the enhancement/add-ruby-3-and-head-to-travis branch February 12, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants