Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registrar methods for Domain Prices API #230

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

duduribeiro
Copy link
Contributor

@duduribeiro duduribeiro commented Apr 9, 2021

This commit introduces a new client method for our Domain Prices API:

  • registrar.get_domain_prices - Retrieves the prices for a domain.

It also includes if the domain is premium or not in the response.

@duduribeiro duduribeiro added enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. labels Apr 9, 2021
@duduribeiro duduribeiro self-assigned this Apr 9, 2021
This commit introduces a new client method for our Domain Prices API:
- registrar.get_domain_prices - Retrieves the prices for a domain.

It also includes if the domain is premium or not in the response.
Copy link
Contributor

@OleMchls OleMchls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ole Michaelis <Ole.Michaelis@googlemail.com>
lib/dnsimple/client/registrar.rb Outdated Show resolved Hide resolved
duduribeiro and others added 2 commits April 13, 2021 09:49
Co-authored-by: Santiago Traversa <san983@users.noreply.github.com>
@duduribeiro duduribeiro merged commit beda5fe into main Apr 19, 2021
@duduribeiro duduribeiro deleted the implement_domain_prices branch April 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants