Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the inexistent domain#reset_domain_token method #231

Merged
merged 1 commit into from Apr 13, 2021
Merged

Drop the inexistent domain#reset_domain_token method #231

merged 1 commit into from Apr 13, 2021

Conversation

duduribeiro
Copy link
Contributor

@duduribeiro duduribeiro commented Apr 12, 2021 •
edited

See dnsimple/dnsimple-developer#187

We dropped the method from the API but we didn't remove it from some
clients. This commit drops this inexistent method.

@duduribeiro
Drop the inexistent domain#reset_domain_token method
f87abb0 
See dnsimple/dnsimple-developer#187 and
https://github.com/dnsimple/dnsimple-app/pull/14061

We dropped the method from the API but we didn't remove it from some
clients. This commit drops this inexistent method.
@duduribeiro duduribeiro added bug ready-for-review Pull requests that are ready to be reviewed by other team members. requires-major-release labels Apr 12, 2021
@duduribeiro duduribeiro self-assigned this Apr 12, 2021
weppos
weppos approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware this change requires to ship 6.0.0.

@weppos weppos added enhancement and removed bug labels Apr 13, 2021
san983
san983 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@san983 san983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ As a major release is needed we could also clear some deprecations we have :)

@duduribeiro
Copy link
Contributor Author

LGTM ✅ As a major release is needed we could also clear some deprecations we have :)

Good point. I will work on the deprecations as well

@duduribeiro duduribeiro merged commit 3cd6444 into main Apr 13, 2021
@duduribeiro duduribeiro deleted the remove_reset_domain_token branch April 13, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weppos weppos weppos approved these changes

@san983 san983 san983 approved these changes

Assignees

@duduribeiro duduribeiro

Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. requires-major-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duduribeiro @weppos @san983