Implement registrar/checkDomain

[jacegu]

No description provided.

[jacegu]

A couple things that I wanted to mention:

1. The check vs. availability naming was somewhat confusing to me.
2. For some reason I feel like the request should use domain_name instead of domain (I had the feeling that domain should be a Dnsimple::Struct::Domain instance).
3. I maintained attributes and options to keep interfaces consistent even if this is a get request and without knowing if there is a use case for it.

[weppos]

The correct path should be "/%s/registrar/domains/%s/check". Did you get this path from somewhere? It may be an outdated docs.

[jacegu]

Yes. At least in the RAML file. I think I saw it somewhere else. I will add it here if I find it.

[weppos]

I've fixed the RAML file, thanks.

[weppos]

The check vs. availability naming was somewhat confusing to me.

I agree, it partially is. We originally used /availability because /domains/check was too generic, but now that we moved all under /registrar I'm fine to keep reference "check".

In fact, I suggest to rename Structs::Availability to Structs::DomainCheck to maintain consistency across different clients.

[weppos]

For some reason I feel like the request should use domain_name instead of domain (I had the feeling that domain should be a Dnsimple::Struct::Domain instance).

Fine for me, in fact register already uses domain_name. FYI, consider we never accept a Domain struct in any call.

I maintained attributes and options to keep interfaces consistent even if this is a get request and without knowing if there is a use case for it.

Attributes is not required. There are no parameters in the payload. attributes generally represent a POST body payload.

[jacegu]

Fine for me, in fact register already uses domain_name. FYI, consider we never accept a Domain struct in any call.

I think I didn't explain myself here. What I mean is that Struct::Availability has a domain instead of a domain_name. This comes from the API endpoint directly so the change should be done on the API side so the serialization returns the name of the domain under domain_name in the payload.

[weppos]