Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error detecting content type #95

Merged
merged 4 commits into from
Apr 8, 2016
Merged

Fix error detecting content type #95

merged 4 commits into from
Apr 8, 2016

Conversation

jacegu
Copy link
Contributor

@jacegu jacegu commented Mar 31, 2016

This is a consequence of #94. That PR didn't consider the charset that may be part of the Content-Type header.

This introduces the usage of a fixture and probes that the detection of
the content type is buggy.
@jacegu jacegu self-assigned this Mar 31, 2016
@jacegu jacegu added bug ready-for-review Pull requests that are ready to be reviewed by other team members. labels Mar 31, 2016
@weppos
Copy link
Member

weppos commented Apr 2, 2016

Makes sense! 👍

FYI, if we need a simple match at the beginning of a string, I'd use String.start_with? which is slightly more efficient than a regexp match.

@jacegu
Copy link
Contributor Author

jacegu commented Apr 2, 2016

if we need a simple match at the beginning of a string, I'd use String.start_with? which is slightly more efficient than a regexp match.

👍 Changing it. Is there somewhere where I can read about this (in other words: how do you know it's more efficient)?

* master:
  Remove Domain token authentication (closes GH-92)
  Sync Rubocop with the base .rubocop_dnsimple.yml file
@weppos
Copy link
Member

weppos commented Apr 7, 2016

:shipit:

@jacegu jacegu merged commit ff4c150 into master Apr 8, 2016
@jacegu jacegu deleted the bugfix/400-content-type branch April 8, 2016 05:10
weppos added a commit that referenced this pull request Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants