Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure 404 page in netlify #737

Merged
merged 1 commit into from Feb 17, 2021
Merged

Configure 404 page in netlify #737

merged 1 commit into from Feb 17, 2021

Conversation

sbastn
Copy link
Member

@sbastn sbastn commented Feb 17, 2021 •
edited

Fixes #736

Belongs to https://github.com/dnsimple/dnsimple-business/issues/946

QA

Visit a page that doesn't exist on the preview site on this PR: https://deploy-preview-737--dnsimple-support.netlify.app/foo

@sbastn sbastn added the task One or more no-coding actions to execute for this project. label Feb 17, 2021
@sbastn sbastn self-assigned this Feb 17, 2021
@sbastn sbastn requested a review from aeden February 17, 2021 09:21
@aeden aeden added site-generator Static site generator bugs or changes. and removed task One or more no-coding actions to execute for this project. labels Feb 17, 2021
aeden
aeden reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@aeden aeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the shadowing behavior in our redirects system, the 404 pages will only be returned for nonexistent assets under the above paths

This should work, approving.

OleMchls
OleMchls approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@OleMchls OleMchls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ https://deploy-preview-737--dnsimple-support.netlify.app/dfgdsfgsdgf

@sbastn sbastn merged commit 163a9f2 into main Feb 17, 2021
@sbastn sbastn deleted the redirecting-to-404-page branch February 17, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeden aeden aeden left review comments

@OleMchls OleMchls OleMchls approved these changes

Assignees

@sbastn sbastn

Labels
site-generator Static site generator bugs or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve 404 looks
3 participants
@sbastn @aeden @OleMchls