Increase test coverage in LookupTest #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibauersachs
requested changes
Feb 3, 2021
nresare
force-pushed
the
lookup_test_coverage
branch
9 times, most recently
from
86b7770
to
bfc1ee0
Compare
ibauersachs
reviewed
Feb 4, 2021
nresare
force-pushed
the
lookup_test_coverage
branch
from
bfc1ee0
to
f9696c1
Compare
nresare
force-pushed
the
lookup_test_coverage
branch
from
f9696c1
to
15146a9
Compare
ibauersachs
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to hit as many code paths in the Lookup.run() as possible. Seems prudent before refactoring :)