Handle leading zeros in (r|s)-parameters of ECDSA signature #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingle
reviewed
May 22, 2019
| break; | ||
| case Algorithm.ECDSAP384SHA384: | ||
| signature = ECDSASignaturefromDNS(signature, | ||
| ECDSA_P384); | ||
| signature = convertECDSASignature(signature); |
There was a problem hiding this comment.
Duplicate branches in switch. If both this case and the one above it are to call the same exact method, would it would be cleaner to:
case Algorithm.ECDSAP256SHA256:
case Algorithm.ECDSAP384SHA384:
signature = convertECDSASignature(signature);
break;
| * verification purposes. | ||
| */ | ||
| public static byte[] convertECDSASignature(byte[] signature) { | ||
| /** |
There was a problem hiding this comment.
Dangling javadoc. Perhaps just use the regular block comment?
| * and | ||
| * https://github.com/gryphius/dnsjava/commit/b4216b35a8386cf47e2c59a875c655d584624d1d | ||
| */ | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per ibauersachs/dnssecjava#14