Properly close UDP channel upon error #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
============================================
+ Coverage 53.14% 53.17% +0.03%
- Complexity 1863 1864 +1
============================================
Files 160 160
Lines 10485 10486 +1
Branches 1524 1524
============================================
+ Hits 5572 5576 +4
+ Misses 4526 4525 -1
+ Partials 387 385 -2
Continue to review full report at Codecov.
|
|
Thanks for the investigation and fix! |
|
No problem at all! Thanks for the quick turnaround. I'll be eagerly waiting for a release :) |
|
Not sure when 3.4 will be out, snapshots are available on Maven Central though. |
|
Or should be if GitHub weren't down... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing an error very similar to the one in #95 - after an error, dnsjava would stop resolving anything and constantly time out. In our case it was also a truncated UDP response, which would fallback to TCP.
Through debugging I discovered that the errored-out channels stayed in the selector, constantly reading -1 and blocking any query sending from happening, making every query time out. What was happening is that
channel.disconnect()was throwing an IOException ("network is unreachable"), so the channel was never closed and thus stuck in the selector. Changing the codepath to always callchannel.close()resolved the issue.