Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continual pushes for GH Pages, remove report #83

Merged
merged 1 commit into from
May 15, 2023

Conversation

MattIPv4
Copy link
Member

Type of Change

  • Build Scripts: GitHub Pages workflow

What issue does this relate to?

cc do-community/available-images#37 do-community/hub-for-good-list#40

What should this PR do?

Comparing the last two hashes pushed to GitHub Pages, the only difference was the report:

git --no-pager diff --no-index --unified=0 ~/Downloads/bandwidth-tool-723f88ba12e7d05f502938ce0fba9aff997be29b ~/Downloads/bandwidth-tool-7cd147aae87f2b445b9cdab49303854f63dbbe0e 
diff --git a/Users/mattcowley/Downloads/bandwidth-tool-723f88ba12e7d05f502938ce0fba9aff997be29b/report.html b/Users/mattcowley/Downloads/bandwidth-tool-7cd147aae87f2b445b9cdab49303854f63dbbe0e/report.html
index 6154786..65dfb82 100644
--- a/Users/mattcowley/Downloads/bandwidth-tool-723f88ba12e7d05f502938ce0fba9aff997be29b/report.html
+++ b/Users/mattcowley/Downloads/bandwidth-tool-7cd147aae87f2b445b9cdab49303854f63dbbe0e/report.html
@@ -6 +6 @@
-    <title>bandwidth-tool [14 May 2023 at 15:09]</title>
+    <title>bandwidth-tool [13 May 2023 at 15:09]</title>

We don't actually need that report in the GitHub Pages output at all, and it is causing us to push every single run, rather than only when the output actually changes. This PR removes the report from the output so that we don't continually push to pages.

What are the acceptance criteria?

Report removed from GitHub Pages output.

@MattIPv4 MattIPv4 merged commit 02ab330 into master May 15, 2023
2 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-gh-pages-pushes branch May 15, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants