Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow URL anchor to work correctly #51

Merged
merged 1 commit into from Aug 9, 2019
Merged

Allow URL anchor to work correctly #51

merged 1 commit into from Aug 9, 2019

Conversation

IAmJSD
Copy link
Contributor

@IAmJSD IAmJSD commented Aug 9, 2019 •
edited

Fixes: #50

@IAmJSD IAmJSD requested a review from MattIPv4 August 9, 2019 10:37
@MattIPv4 MattIPv4 changed the title Fixed a bug where anchors do not jump properly (Fixes #50) Allow URL anchor to work correctly Aug 9, 2019
MattIPv4
MattIPv4 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Squash & merge.

@MattIPv4 MattIPv4 merged commit 59200c2 into master Aug 9, 2019
@MattIPv4 MattIPv4 deleted the anchor_fix branch August 13, 2019 15:51
@MattIPv4 MattIPv4 mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchor links don't work
2 participants
@IAmJSD @MattIPv4