Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engage siteAdapters, err details to console #5

Merged
merged 14 commits into from Mar 21, 2019
Merged

Conversation

WardCunningham
Copy link
Collaborator

Here we use LINEUP to diagram pages from both http and https sites. With this now working we can consider how other algorithmic markup can see deeper into the federation.

image

@WardCunningham
Copy link
Collaborator Author

Remove MEHAFFY & diagram()
Add Redirect argument to DOT keyword.
Add new about pages including MEHAFFY replacement.

@WardCunningham
Copy link
Collaborator Author

I've changed the redirect syntax to be more readable and unambiguous at the same time by signaling redirect with DOT FROM.

I had overloaded the DOT keyword in a way that DOT graph could have two meanings. At first I didn't consider this a serious problem because a page named Graph would have to contain a Graphviz plugin before the second meaning would be unavailable. But why be so clever.

image

Oops. Didn't mean to commit to master here. Will merge locally to
complete branch commit then fix master later.
@paul90
Copy link
Collaborator

paul90 commented Mar 15, 2019

As discussed, this looks good for publishing a next tagged version from this branch.

@WardCunningham
Copy link
Collaborator Author

This fetch fails on ghost page.

image

Debugging with "Pause on Exception" we find this code in jQuery-migrate that is trying to catch this error but not getting the null that it expected.

image

We are having trouble ignoring ghost pages like search
results when encountered in the lineup. See comment:
#5
This is our second attempt to catch a get error,
this time on the outside of an await.
See #5
@WardCunningham
Copy link
Collaborator Author

Lineup Diagram once again readily retrieved by searching for it. Here is my rather complicated test case that had be caught in an edit-publish-debug loop.

image

@WardCunningham
Copy link
Collaborator Author

We now accept DOT FROM with or without a \n.
We report slightly better error messages when the redirect doesn't work.

image

@WardCunningham
Copy link
Collaborator Author

Add widely useful Lineup Diagram to about pages.

image

@WardCunningham
Copy link
Collaborator Author

We now include a brief enumeration of RegExp Metacharacters which is cited in the More About Algorithmic Markup page. This would otherwise be a broken link on most sites.

image

Copy link
Owner

@dobbs dobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me. I offer one suggestion for logging an error and one reminder after we've merged this PR

client/graphviz.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Co-Authored-By: paul90 <paul.rodwell@btinternet.com>
Copy link
Collaborator

@paul90 paul90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added the suggested error message on the get rather than swallowing the error.

@paul90 paul90 merged commit d74cf8f into master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants