New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engage siteAdapters, err details to console #5
Conversation
Remove MEHAFFY & diagram() |
I've changed the redirect syntax to be more readable and unambiguous at the same time by signaling redirect with I had overloaded the DOT keyword in a way that |
Oops. Didn't mean to commit to master here. Will merge locally to complete branch commit then fix master later.
As discussed, this looks good for publishing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good to me. I offer one suggestion for logging an error and one reminder after we've merged this PR
Co-Authored-By: paul90 <paul.rodwell@btinternet.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've added the suggested error message on the get rather than swallowing the error.
Here we use LINEUP to diagram pages from both http and https sites. With this now working we can consider how other algorithmic markup can see deeper into the federation.