Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options not working #63

Closed
JshGrn opened this issue Mar 4, 2021 · 6 comments
Closed

Options not working #63

JshGrn opened this issue Mar 4, 2021 · 6 comments

Comments

@JshGrn
Copy link

JshGrn commented Mar 4, 2021

Hi there,

Used your plugin flawlessly throughout all my projects however having difficulty in settings options in a new Vue3 project.

VJS Devtools I can see that options are being passed correctly but it looks like they are not being passed to the player?

image

Responsive is not working, but I have tried a few options and it looks like none of them work...

Thank you,
Josh

@JshGrn
Copy link
Author

JshGrn commented Mar 4, 2021

It looks like options are not being passed down via mergeOptions, if I specify the options within ops they are passed to the player correctly.

@JshGrn
Copy link
Author

JshGrn commented Mar 4, 2021

Line 90 is returning opts without merging with props.options, could we change:

return opts;

to

return Object.assign(opts, props.options);

@dobromir-hristov
Copy link
Owner

Yep, I have just forgotten to do so. Please make a PR.

@JshGrn
Copy link
Author

JshGrn commented Mar 4, 2021

Yep, I have just forgotten to do so. Please make a PR.

I am unable to do that at the minute but I will when I can.. Thanks!

@dobromir-hristov
Copy link
Owner

Published

@JshGrn
Copy link
Author

JshGrn commented Mar 4, 2021

Published

Excellent, thank you very much. Top man!

@JshGrn JshGrn closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants