Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dotted focus state #50

Closed
ajb opened this issue Mar 10, 2015 · 1 comment · Fixed by #51
Closed

Remove dotted focus state #50

ajb opened this issue Mar 10, 2015 · 1 comment · Fixed by #51
Assignees
@ajb

Comments

@ajb
Copy link
Contributor

ajb commented Mar 10, 2015

Did we actually design this? I think it might be a relic of cardinal (the CSS framework). It's ugly and distracting IMO.

http://take.ms/xZBof
@ajb ajb assigned jrubenoff and ajb and unassigned jrubenoff Mar 10, 2015
ajb added a commit that referenced this issue Mar 10, 2015
@ajb
fix focus states
a6481a5 
closes #50

cribbing from bootstrap, this looks good though... "auto" seems to give
us the great behavior of only showing the focus ring when tabbing
through, not on click.
@ajb ajb mentioned this issue Mar 10, 2015
Merged
@ajb ajb closed this as completed Mar 10, 2015
@jrubenoff
Copy link
Contributor

Yeah, I have that in dobtco/screendoor-v2#1089. Ideally we'd have consistent focus states for links, buttons, etc. that were nicer than a ring and more consistent with our hover / active states. Your PR looks good for now, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajb ajb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix focus states dobtco/dvl-core
2 participants
@ajb @jrubenoff