Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent flashes with actions #88

Closed
jrubenoff opened this issue May 14, 2015 · 5 comments
Closed

Persistent flashes with actions #88

jrubenoff opened this issue May 14, 2015 · 5 comments

Comments

@jrubenoff
Copy link
Contributor

Outcomes

  • Make it more visually obvious when flashes contain actions.
  • Give users enough time to read, understand and perform actions contained in flashes.

Structure

If a flash contains a button, that flash should stay onscreen until the user performs another action or goes to a different page.

Currently this disappears after 10 seconds:

screen shot 2015-05-14 at 1 15 37 pm

Visual

Rough mockup:

screen shot 2015-05-14 at 1 19 18 pm

@ajb
Copy link
Contributor

ajb commented May 14, 2015

I thought about this too. How will this be reconciled with the animations
though?

On Thu, May 14, 2015 at 4:21 PM, Josh Rubenoff notifications@github.com
wrote:

Outcomes

  • Make it more visually obvious when flashes contain actions.
  • Give users enough time to read, understand and perform actions
    contained in flashes.

Structure

If a flash contains a button, that flash should stay onscreen until the
user performs another action or goes to a different page.

Currently this disappears after 10 seconds:

[image: screen shot 2015-05-14 at 1 15 37 pm]
https://cloud.githubusercontent.com/assets/1328849/7641022/f38d2074-fa3b-11e4-8e9e-12c2f34cd424.png
Visual

Rough mockup:

[image: screen shot 2015-05-14 at 1 19 18 pm]
https://cloud.githubusercontent.com/assets/1328849/7641031/02a89836-fa3c-11e4-9ac8-924f60612fe9.png


Reply to this email directly or view it on GitHub
#88.

Adam Becker
(951) 9-BECKER
@AdamJacobBecker

@jrubenoff
Copy link
Contributor Author

Don't trigger hide() unless the user performs another action on the page?

@ajb
Copy link
Contributor

ajb commented May 14, 2015

What I mean is: what happens when there are three flashes in a row, and the
middle one is persistent?

On Thu, May 14, 2015 at 5:53 PM, Josh Rubenoff notifications@github.com
wrote:

Don't trigger hide() unless the user performs another action on the page?


Reply to this email directly or view it on GitHub
#88 (comment).

Adam Becker
(951) 9-BECKER
@AdamJacobBecker

@jrubenoff
Copy link
Contributor Author

Can you give a real-world example?

The bottom flash would only occur if the user did something after they triggered the persistent middle flash, right? So the middle flash would hide.

@ajb
Copy link
Contributor

ajb commented Jun 3, 2015

Moving to #83.

@ajb ajb closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants