Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload to confluence breaks with embedded images #1163

Closed
PacoVK opened this issue May 10, 2023 · 2 comments · Fixed by #1166
Closed

upload to confluence breaks with embedded images #1163

PacoVK opened this issue May 10, 2023 · 2 comments · Fixed by #1166
Labels
🐞 bug
Milestone
Java 17

Comments

@PacoVK
Copy link
Collaborator

PacoVK commented May 10, 2023

Describe the bug
Due to the solution for #425 we introduced the data-uri setting for asciidoctor.
This breaks now the :publishToConfluence task.

To Reproduce
Steps to reproduce the behavior:

  1. run :generateHTML task on a document with images
  2. run :publishToConfluence
  3. See error

Expected behavior
No error and document is published to Confluence

Screenshots
If applicable, add screenshots to help explain your problem.

Configuration

  • docToolchain latest
  • OS: all
  • Relevant SDK Versions all supported

Additional context
We have two possible solutions:

  1. we don't support the requirement of fail on missing images #425 - we cannot fail on missing images, optional you can set data-uri on your own, this will then support for failing images. You cannot use :publishToConfluence then.
  2. we implement changes in :publishToConfluence that can handle embedded images. This means embedded images need to be "unembedded" and uploaded to confluence, since confluence is not able to handle embedded images.
@PacoVK PacoVK added this to the Java 17 milestone May 10, 2023
PacoVK referenced this issue May 10, 2023
@PacoVK @mh182
Migrate gradle-asciidoc plugin to v 3.x
4556c35 
Use asciidoctor slides plugin for revealJS.
Fix the AsciidoctorSpec and move output to global build folder.
Remove code to clone reveal.js git repository.
Document corresponding Asciidoctor reveal.js config, to ease overwrite.
Add a hint to docs for RevealJS specific config.
@PascalWillig
Copy link

I prefer solution one but rather like this:
data-uri option (true/false) in the generateHTML which is overwritten with false when publishToConfluence is called.

@PacoVK PacoVK mentioned this issue May 10, 2023
Merged
3 tasks
@PacoVK
Copy link
Collaborator Author

PacoVK commented May 10, 2023

i think with the PR that implements option 2 we can have both, embedded images (a requirement for fail on missing images) and the same behaviour as it is as of now in v2.x

@mh182 mh182 linked a pull request May 12, 2023 that will close this issue
Fix/confluence export #1166
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
Java 17
Development

Successfully merging a pull request may close this issue.

Fix/confluence export PacoVK/docToolchain
2 participants
@PacoVK @PascalWillig