Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/confluence export #1166

Merged
merged 1 commit into from
May 12, 2023
Merged

Fix/confluence export #1166

merged 1 commit into from
May 12, 2023

Conversation

PacoVK
Copy link
Collaborator

@PacoVK PacoVK commented May 10, 2023 •
edited

This PR addresses #1163

  • Changes in :publishToConfluence that this task can handle embedded images
  • Configure if build should fail on missing images

All Submissions:

  • Did you update the changelog.adoc?
  • Does your PR affect the documentation?
  • If yes, did you update the documentation or create an issue for updating it?

@netlify
Copy link

netlify bot commented May 10, 2023 •
edited

✅ Deploy Preview for dtc-docs-preview ready!

Name Link
🔨 Latest commit 0593ee4
🔍 Latest deploy log https://app.netlify.com/sites/dtc-docs-preview/deploys/645e9316ba1bbe00088cfcd0
😎 Deploy Preview https://deploy-preview-1166--dtc-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PacoVK
Copy link
Collaborator Author

PacoVK commented May 10, 2023

This solution is open for discussion, still missing the update of the documentation. I'd like to have some feedback especially for the new config property ignoreMissingImages

@mh182 mh182 linked an issue May 12, 2023 that may be closed by this pull request
upload to confluence breaks with embedded images #1163
Closed
mh182
mh182 approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@mh182 mh182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the 3 commits to one, rebase and then merge.

@PacoVK
make 'data-uri' configurable
0593ee4 
handle embedded images and allow them for export to confluence
@PacoVK PacoVK self-assigned this May 12, 2023
@PacoVK PacoVK merged commit 0726473 into docToolchain:ng May 12, 2023
11 checks passed
@PacoVK PacoVK deleted the fix/confluence_export branch May 12, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mh182 mh182 mh182 approved these changes

Assignees

@PacoVK PacoVK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upload to confluence breaks with embedded images
2 participants
@PacoVK @mh182