-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite arch with x86_64 in case of i386 #1084
base: ng
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for dtc-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
on a windows machine, |
@mh182 please merge if you also think this is ok |
To be honest, just looking at those 5 lines of codes, in a couple of weeks, no one is going to understand them. At least I would not.
So if we don't provide some context with the code (and maybe a reference to ticket #1082) I would refactor the code and delete those lines in a couple of weeks. @SimonCW So how about providing a bit of documentation and explain why we have this strange code in there? |
TBH, I'm not sure whether it should be in there at all. It might be that it is just a weirdness of my config on my Mac that it outputs:
I didn't have time to investigate on my machine or research whether this is expected behavior. Just wanted to share my solution. I can check with a few colleagues that have the same machine next week. And try to find out how reliable arch / uname is for determining architecture. 😜 |
So, regarding the answer of chatgpt, |
All Submissions:
changelog.adoc
?The source of the documentation can be found in
/src/docs/
.If you didn't find the time to update docs, please create an issue as reminder to do so.
Your first submission
As discussed here: #1082