Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishToConfluence: Fix comparision error for titles with leading/trailing white spaces #1246

Merged
merged 2 commits into from Sep 12, 2023

Conversation

MichaelRossner
Copy link
Contributor

@MichaelRossner MichaelRossner commented Sep 11, 2023

Fix a problem with different compare results of "pageExists" between docToolchain and Confluence.

If the title of a page has trailing or leading spaces it will be removed by Confluence on upload. This leads to different results for the comparison in docToolchain == "No" and Confluence == "Yes".

This in turn triggers an upload of the page to Confluence - where it is rejected. Finally the user gets a
"A page with this title already exists: A page already exists with the title <TITLE> in the space with key
please check the ancestorId in your config file"

All Submissions:

  • Did you update the changelog.adoc?
  • Does your PR affect the documentation?
  • If yes, did you update the documentation or create an issue for updating it?

The source of the documentation can be found in /src/docs/.

If you didn't find the time to update docs, please create an issue as reminder to do so.

Your first submission

  • Welcome to the list of contributors! If you have any questions, feel free to ask them by creating a new issue
  • Have you added your name to the list of 30_community.adoc?

inspiration: https://github.com/stevemao/github-issue-templates

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for dtc-docs-preview ready!

Name Link
🔨 Latest commit f532495
🔍 Latest deploy log https://app.netlify.com/sites/dtc-docs-preview/deploys/6500849b8511240007f4fd49
😎 Deploy Preview https://deploy-preview-1246--dtc-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fix a problem with different compare results of "pageExists" between docToolchain and Confluence.

If the title of a page has trailing or leading spaces it will be removed by Confluence on upload. This leads to different results for the comparison in docToolchain == "No" and Confluence == "Yes".

This in turn triggers an upload of the page to Confluence - where it is rejected.
Finally the user gets a
"A page with this title already exists: A page already exists with the title <TITLE> in the space with key <SPACE>
please check the ancestorId in your config file"
Copy link
Collaborator

@PacoVK PacoVK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙏 LGTM

@rdmueller rdmueller merged commit 953dba0 into docToolchain:ng Sep 12, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants