docs: adding field descriptions to predefined image document #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
+ Coverage 83.73% 83.87% +0.13%
==========================================
Files 136 136
Lines 9040 9041 +1
==========================================
+ Hits 7570 7583 +13
+ Misses 1470 1458 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
2 times, most recently
from
fb2edac
to
1766ca5
Compare
JoanFM
requested changes
Sep 4, 2023
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
2 times, most recently
from
0875819
to
9be3411
Compare
JoanFM
requested changes
Sep 6, 2023
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
from
9be3411
to
0511713
Compare
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
2 times, most recently
from
008c51f
to
0eb7502
Compare
JoanFM
requested changes
Sep 14, 2023
|
To resolve the conflicts, make sure to add None as the default value for the Optional fields. |
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
from
0eb7502
to
9e21a5a
Compare
JoanFM
requested changes
Sep 14, 2023
|
Weird, must've gotten added while rebasing the changes. Will fix the quotes |
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
2 times, most recently
from
9f82327
to
061510a
Compare
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
punndcoder28
force-pushed
the
docs_adding_field_description_image_document
branch
from
061510a
to
794da80
Compare
JoanFM
approved these changes
Sep 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagedocument