Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding field descriptions to predefined audio document #1774

Conversation

punndcoder28
Copy link
Contributor

@punndcoder28 punndcoder28 commented Sep 5, 2023

  • Adds field descriptions and example usage of each field for the predefined Audio document

@punndcoder28 punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from 106b51c to be3e2ee Compare September 5, 2023 17:18
@punndcoder28 punndcoder28 marked this pull request as ready for review September 5, 2023 17:20
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (715252a) 83.73% compared to head (c3097df) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
+ Coverage   83.73%   83.87%   +0.13%     
==========================================
  Files         136      136              
  Lines        9040     9041       +1     
==========================================
+ Hits         7570     7583      +13     
+ Misses       1470     1458      -12     
Flag Coverage Δ
docarray 83.87% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/documents/audio.py 92.85% <100.00%> (+0.26%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docarray/documents/audio.py Outdated Show resolved Hide resolved
@punndcoder28 punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from be3e2ee to 8a7538d Compare September 6, 2023 17:59
@punndcoder28 punndcoder28 force-pushed the docs_adding_field_description_audio_document branch 2 times, most recently from f47ba11 to f9a1871 Compare September 8, 2023 17:04
docarray/documents/audio.py Outdated Show resolved Hide resolved
docarray/documents/audio.py Outdated Show resolved Hide resolved
docarray/documents/audio.py Outdated Show resolved Hide resolved
docarray/documents/audio.py Outdated Show resolved Hide resolved
docarray/documents/audio.py Outdated Show resolved Hide resolved
@JoanFM
Copy link
Member

JoanFM commented Sep 14, 2023

To resolve the conflicts, make sure to add None as the default value for the Optional fields.

@punndcoder28 punndcoder28 force-pushed the docs_adding_field_description_audio_document branch 2 times, most recently from bd495f4 to ad71930 Compare September 14, 2023 16:51
@punndcoder28
Copy link
Contributor Author

Fixed the typo and removed '''...''' wherever it was not needed

docarray/documents/audio.py Outdated Show resolved Hide resolved
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
@punndcoder28 punndcoder28 force-pushed the docs_adding_field_description_audio_document branch from ad71930 to c3097df Compare September 14, 2023 17:32
@JoanFM JoanFM merged commit 35d2138 into docarray:main Sep 14, 2023
36 of 40 checks passed
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants