Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sign commit commad in docs #1834

Merged
merged 1 commit into from Dec 4, 2023

Conversation

ai-naymul
Copy link
Contributor

Screenshot_3

The command is not correct in the CONTRIBRUTING.md file
in this commit the command is corrected in the file

@JoanFM
Copy link
Member

JoanFM commented Dec 2, 2023

Hey @ai-naymul ,

We need you to sign off the commit

@ai-naymul
Copy link
Contributor Author

Hey @ai-naymul ,

We need you to sign off the commit

I hate the DCO, I always forgot to add the sign😪
Let me fix that

@ai-naymul
Copy link
Contributor Author

ai-naymul commented Dec 4, 2023

Hey @ai-naymul ,

We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out.
Screenshot_4

@JoanFM
Copy link
Member

JoanFM commented Dec 4, 2023

Hey @ai-naymul ,
We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out. Screenshot_4

I do not know how to solve it, what if u create a nee PR from a fresh branch with the commit signed off from start

@ai-naymul
Copy link
Contributor Author

ai-naymul commented Dec 4, 2023

Hey @ai-naymul ,
We need you to sign off the commit

@JoanFM I am getting the following error would you mind helping me to out this, In tried different methods but didn't work out. Screenshot_4

I do not know how to solve it, what if u create a nee PR from a fresh branch with the commit signed off from start

I am also getting this error when I try to sign my commit not only for this case

This error is only getting when try to sign commit otherwise commiting is working

@JoanFM
Copy link
Member

JoanFM commented Dec 4, 2023

have u googled it?

@JoanFM
Copy link
Member

JoanFM commented Dec 4, 2023

@ai-naymul
Copy link
Contributor Author

have u googled it?

Yeah tried different methods but didn't solved

@ai-naymul
Copy link
Contributor Author

Have u checked here? https://gist.github.com/paolocarrasco/18ca8fe6e63490ae1be23e84a7039374

Let me try it

Signed-off-by: Naymul Islam <naymul504@gmail.com>
@ai-naymul
Copy link
Contributor Author

Ahhh.. Finally @JoanFM could you please check is everything fine :)
btw thanks for referring

@JoanFM JoanFM changed the title fix(docs): fix sign commit commad in docs docs: fix sign commit commad in docs Dec 4, 2023
@JoanFM JoanFM merged commit 82918fe into docarray:main Dec 4, 2023
34 of 36 checks passed
@JoanFM JoanFM mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants