Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with conda install option #22

Closed
wants to merge 1 commit into from

Conversation

sugatoray
Copy link

Updated docs. This PR is representative (qualitatively) of the work involved in the PR (conda-forge/staged-recipes#17482) to add docarray to conda-forge channel.

  • readme (install instruction + badges)
  • docs (index.md: conda install only)

This closes #21 .

@hanxiao
Copy link
Member

hanxiao commented Jan 10, 2022

great work! should i merge after conda-forge/staged-recipes#17482 is merged, right?

@hanxiao
Copy link
Member

hanxiao commented Jan 10, 2022

btw could you do

git commit --amend

and fix your commit to build: add conda-install

then git push --force

@sugatoray
Copy link
Author

great work! should i merge after conda-forge/staged-recipes#17482 is merged, right?

You can go ahead even now. It is already available (by the time I opened the issue, the conda-forge PR was already merged).

$ conda search -c conda-forge docarray
Loading channels: done
# Name                       Version           Build  Channel             
docarray                       0.1.2    pyhd8ed1ab_0  conda-forge

@sugatoray
Copy link
Author

I could not get time to amend the comment yet. I will do it tomorrow.

@sugatoray
Copy link
Author

Hi @hanxiao,

There was another typo in the badges. Fixed it and committed the update with the comment you had suggested. Looks like there is a conflict. Please feel free to make changes as you see fit.

@hanxiao hanxiao closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a conda install option for docarray
2 participants