Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use list for DocumentArrayInMemory #239

Merged
merged 7 commits into from Mar 31, 2022
Merged

Conversation

alaeddine-13
Copy link
Member

closes: #209

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #239 (e826a52) into main (807bdb1) will decrease coverage by 0.66%.
The diff coverage is 97.59%.

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   85.81%   85.15%   -0.67%     
==========================================
  Files         131      131              
  Lines        5921     6001      +80     
==========================================
+ Hits         5081     5110      +29     
- Misses        840      891      +51     
Flag Coverage Δ
docarray 85.15% <97.59%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/base/getsetdel.py 91.30% <50.00%> (-0.74%) ⬇️
docarray/array/storage/memory/getsetdel.py 95.91% <97.29%> (-4.09%) ⬇️
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/array/storage/memory/backend.py 97.50% <100.00%> (+2.50%) ⬆️
docarray/array/storage/memory/seqlike.py 100.00% <100.00%> (ø)
docarray/array/mixins/reduce.py 28.57% <0.00%> (-67.86%) ⬇️
docarray/array/mixins/group.py 61.53% <0.00%> (-25.65%) ⬇️
docarray/array/mixins/content.py 86.15% <0.00%> (-12.31%) ⬇️
docarray/array/mixins/io/pbar.py 88.88% <0.00%> (-11.12%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af5af3...e826a52. Read the comment docs.

@hanxiao hanxiao linked an issue Mar 30, 2022 that may be closed by this pull request
@hanxiao hanxiao merged commit c552fdf into main Mar 31, 2022
@hanxiao hanxiao deleted the refactor-dam-list branch March 31, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docarray copy=True switch to list container for DocumentArrayInMemory
2 participants