Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve mesh data loading #25

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix: improve mesh data loading #25

merged 1 commit into from
Jan 11, 2022

Conversation

numb3r3
Copy link
Contributor

@numb3r3 numb3r3 commented Jan 11, 2022

deduplicated() would throw divide by zero error in some cases.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #25 (4f54c64) into main (e62c1ad) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   82.84%   82.93%   +0.08%     
==========================================
  Files          67       67              
  Lines        3137     3135       -2     
==========================================
+ Hits         2599     2600       +1     
+ Misses        538      535       -3     
Flag Coverage Δ
docarray 82.93% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/mixins/mesh.py 93.33% <100.00%> (+16.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62c1ad...4f54c64. Read the comment docs.

@hanxiao hanxiao merged commit 09c5c43 into main Jan 11, 2022
@hanxiao hanxiao deleted the fix-mesh-loader branch January 11, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants