fix(array): fix edge case on single boolean index #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/s
area/core
area/docs
area/testing
component/array
labels
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 82.93% 83.09% +0.15%
==========================================
Files 67 67
Lines 3135 3135
==========================================
+ Hits 2600 2605 +5
+ Misses 535 530 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
davidbp
reviewed
Jan 11, 2022
| @@ -120,6 +120,8 @@ print(da) | |||
| <DocumentArray (length=50) at 4513619088> | |||
| ``` | |||
|
|
|||
| Note that if the length of the boolean mask is smaller than the length of a DocumentArray, then the remaining part is padded to `False`. | |||
There was a problem hiding this comment.
I would add 'The length of the boolean mask should be at least 2'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.