Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter_dict works with zero and empty str #332

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

numb3r3
Copy link
Contributor

@numb3r3 numb3r3 commented May 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #332 (0bf12c8) into main (1e7ba61) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         134      134           
  Lines        6316     6316           
=======================================
  Hits         5444     5444           
  Misses        872      872           
Flag Coverage Δ
docarray 86.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/helper.py 76.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91d21e...0bf12c8. Read the comment docs.

@numb3r3 numb3r3 requested a review from davidbp May 10, 2022 03:19
@alaeddine-13 alaeddine-13 merged commit c556098 into main May 10, 2022
@alaeddine-13 alaeddine-13 deleted the fix-filter-config branch May 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants