Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply hnsw parameters to the main class not the meta class #337

Merged
merged 2 commits into from
May 11, 2022

Conversation

alaeddine-13
Copy link
Member

@alaeddine-13 alaeddine-13 commented May 11, 2022

fix: apply hnsw parameters to the main class not the meta class
closes: #336

to test:

da = DocumentArray(storage='weaviate', config={'n_dim': 100, 'ef': 100, 'ef_construction': 100, 'max_connections': 16})

and check the schema:

curl localhost:8080/v1/schema

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #337 (bd4da94) into main (8df37c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files         134      134           
  Lines        6316     6316           
=======================================
  Hits         5444     5444           
  Misses        872      872           
Flag Coverage Δ
docarray 86.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/backend.py 87.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df37c3...bd4da94. Read the comment docs.

Copy link
Contributor

@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge, there should be some test to cover this

@alaeddine-13
Copy link
Member Author

Do not merge, there should be some test to cover this

@JoanFM added, can you re-check ?

@JoanFM JoanFM merged commit f52e8e2 into main May 11, 2022
@JoanFM JoanFM deleted the fix-weaviate-hnsw-parameters branch May 11, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weaviate hnsw parameters are applied to the Meta class instead of the main class
3 participants