-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: single doc set in docarray #42
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 82.80% 82.58% -0.22%
==========================================
Files 67 67
Lines 3193 3216 +23
==========================================
+ Hits 2644 2656 +12
- Misses 549 560 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will take this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
Currently setting for example
.text
the attribute for a concreteDocument
in aDocumentArray
results to setting the first character in the string.In master
This happens because the setter has the sets the values in
for _d, _vv in zip(_docs, _v)
and when the input data is an iterable this is not probably what the user would expectIn this PR