fix: use os urandom to generate doc id #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing #462
hi guys, there is a bug in docarray Document.id, it is affected by random.seed() , see the behavior here:
then you will find:
Expected behavior:
Doc ID should not be controlled by random.seed/numpy.seed/torch.seed etc.
Unexpected behavior:
Now every doc has the same id, this leads to many other problems in DocArray/push/pull/persist/all kinds of API. It is also the side-effect that user unexpected when using DocArray.
Solution:
use
os.urandom(16).hex()
for doc.id generation, a bit slower but faster thanuuid1
but it is independent from seed generation.This bug is sneaky and very unexpected, which caused https://jina-ai.slack.com/archives/C0169V26ATY/p1658429345447309
In general, the current design of ID generation is a flaw as it was not put into computational-intensive/real numerical application.