refactor(array): use extend in add improve docs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 82.76% 82.75% -0.02%
==========================================
Files 70 70
Lines 3331 3329 -2
==========================================
- Hits 2757 2755 -2
Misses 574 574
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
📝 Docs are deployed on https://ft-refactor-add-array--jina-docs.netlify.app 🎉 |
JoanFM
reviewed
Jan 15, 2022
| for doc in other: | ||
| v.append(doc) | ||
| v.extend(self) | ||
| v.extend(other) |
There was a problem hiding this comment.
why not self.extend(other) and return self?
There was a problem hiding this comment.
__add__
a + b
not
__iadd__
a+=b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.