Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document): serialize blob with base64 in dict/json #63

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 18, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #63 (74f51c2) into main (e179ef6) will increase coverage by 0.06%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   82.92%   82.99%   +0.06%     
==========================================
  Files          70       70              
  Lines        3350     3357       +7     
==========================================
+ Hits         2778     2786       +8     
+ Misses        572      571       -1     
Flag Coverage Δ
docarray 82.99% <90.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/__init__.py 76.00% <ø> (+5.62%) ⬆️
docarray/document/pydantic_model.py 95.00% <83.33%> (-2.06%) ⬇️
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/document/mixins/pydantic.py 88.46% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3415670...74f51c2. Read the comment docs.

@hanxiao hanxiao merged commit 79c13a0 into main Jan 18, 2022
@hanxiao hanxiao deleted the fix-blob-binaru branch January 18, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant