Fix #254: Pass structure/@xml:lang to result doc #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass xml:lang attribute on <structure> (without @resourceref) to the root element of the result document. Without this fix, an author cannot set the language of the result document.
|
@bobstayton Do you need anything else for this PR? I would appreciate if we could merge that. Thanks! 馃檪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #254.
Pass
xml:langattribute on<structure>(without@resourceref) to the root element of the result document.Without this fix, an author cannot set the language of the result document.
@bobstayton: This should be easy to review, it's just one line. 馃槈
If we want to go the extra mile, we could use the
xml:langattribute from<assembly>, if there is none on<structure>. Should we take that into account? If yes, the line should look like this: