Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainly improve test code #1349

Merged
merged 30 commits into from
May 9, 2021
Merged

Mainly improve test code #1349

merged 30 commits into from
May 9, 2021

Conversation

Hironsan
Copy link
Member

@Hironsan Hironsan commented May 9, 2021 •
edited

Mainly improve test codes. Reduce issues, duplications, LoC, and so on.
In addition:

  • Remove circular dependencies
  • Change permission of TagList API
  • Add TagDetail API
  • Update flake8 command

Before

image

After

image

Hironsan added 30 commits May 6, 2021 10:23
@Hironsan
Remove unused get_absolute_url method
06612a9
@Hironsan
Move signals from models.py to signals.py
1b00e9b
@Hironsan
Remove circular dependency
6c33281
@Hironsan
Update test cases
5446828
@Hironsan
Add permission to TagList
87da2e3
@Hironsan
Add TagDetail API
8b98c91
@Hironsan
Add test cases for tag API
0269d7b
@Hironsan
Update test cases for project to make it easy to understand
bc7c9e8
@Hironsan
Remove unused imports
0054df4
@Hironsan
Remove unused import
51c510a
@Hironsan
Change fstring to string
97d676f
@Hironsan
Remove unused variable
2acc911
@Hironsan
Remove unused variable
d0df77c
@Hironsan
Update test_user.py
440eab5
@Hironsan
Update test_label.py to make it easy to understand
f205567
@Hironsan
Update test_label.py
48d6bb4
@Hironsan
Simplify test cases
5aae409
@Hironsan
Update test_role.py to make it easy to understand
b43fa7b
@Hironsan
Update test cases to add format=json
fece818
@Hironsan
Add CRUDMixin to remove duplication
5da4e0b
@Hironsan
Update test_comment.py to make it easy to understand
1f80870
@Hironsan
Update test_annotation.py to make it easy to understand
ed47467
@Hironsan
Update test_document.py to make it easy to understand
d5ce4d5
@Hironsan
Update test_models.py
9774d30
@Hironsan
Update flake8 command
acb4768
@Hironsan
Fix files according to flake8
dbb4f63
@Hironsan
Add DEFAULT_AUTO_FIELD to settings.py
2e7cec3
@Hironsan
Update apps.py to use lazy import
89686d4
@Hironsan
Merge remote-tracking branch 'origin/master' into refactoring
902a0a4
@Hironsan
Remove whitespace
8f0946b
@Hironsan Hironsan merged commit 2283cff into master May 9, 2021
@Hironsan Hironsan deleted the refactoring branch May 9, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Hironsan