Remove unneeded query #1442
Merged
Remove unneeded query #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulk create returns the created objects in the same order as they have been added. In Postgres, the query was wrong, because ordering was not guaranteed.
|
Does this work also when exporting the data? I know that there's a filter statement to get the data, but we filter based on |
|
It should work. Attaching the labels to the wrong documents happened at import time. At export time each document is exported with its own labels, as they are in the database.This pull request makes sure that the documents and labels are aligned at import time, so that they are saved properly in the database.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk create returns the created objects in the same order as they have been added.
In Postgres, the query was wrong, because ordering was not guaranteed and sometimes it returned the ids in the wrong order than they were inserted.
This is a simpler fix for #1432, without requiring changes to the model.