Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a check button even for annotators #1473

Merged
merged 9 commits into from
Oct 13, 2021

Conversation

youichiro
Copy link
Member

@youichiro youichiro commented Aug 18, 2021

Issue

#280

What this PR do

  • display check button for all roles including annotator.
    • when the check button is clicked, confirm API is called and an example_state record is created.
  • separate confirmation status for each user.
    • when a project.collaborative_annotation is True, share status by each role.

Before

  • Check button was hidden when user is annotator.
  • The same status was shared by approver and admin.

スクリーンショット 2021-08-19 7 15 00

After

When project.collaborative_annotation is False

  • Each user has an independent example state.

スクリーンショット 2021-08-19 7 15 31

When project.collaborative_annotation is True

  • Each role has an example state.

スクリーンショット 2021-08-19 7 15 41

Screenshot

Check button is displayed even if user is annotator.
スクリーンショット 2021-08-19 6 55 34

Next action idea

  • Display the example status in the annotation screen or dataset page.
    • Approver should want to know the example annotation is completed.
  • Fix filter results
    • If Done is selected, examples confirmed by annotator will be filtered.
  • Change graph displayed on the statistics page.
    • Delete the current completed/Incompleted graph.
    • Added graphs of completed/uncompleted annotations and completed/uncompleted approvals.

@youichiro youichiro force-pushed the annotators_check_their_annotations branch from 5002fcc to 28052f6 Compare August 18, 2021 15:02
@youichiro youichiro marked this pull request as ready for review August 18, 2021 22:52
@Hironsan Hironsan merged commit e90f940 into doccano:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants