Comment out gfpop due to #10.

doccstat · Mar 29, 2024 · 6f41383 · 6f41383
1 parent 5451b53
commit 6f41383
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 27 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -43,7 +43,6 @@ Suggests:
     CptNonPar,
     ecp,
     fpop,
-    gfpop,
     ggplot2,
     gridExtra,
     InspectChangepoint,

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # fastcpd 0.13.1
 
 *   Default no pruning for `lasso`.
+*   Comment out `gfpop` due to https://github.com/doccstat/fastcpd/issues/10.
 
 # fastcpd 0.13.0
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -3,6 +3,7 @@
 ### fastcpd 0.13.1
 
 *   Default no pruning for `lasso`.
+*   Comment out `gfpop` due to https://github.com/doccstat/fastcpd/issues/10.
 
 ### fastcpd 0.13.0
 

diff --git a/vignettes/comparison-packages.Rmd b/vignettes/comparison-packages.Rmd
@@ -30,9 +30,9 @@ All `bcp` code is commented out due to
 ```{r package_installation}
 for (
   package in c(
-    # "bcp",
+    # "bcp", "gfpop",
     "ggplot2", "mvtnorm",
-    "breakfast", "changepoint", "cpm", "CptNonPar", "ecp", "fpop", "gfpop",
+    "breakfast", "changepoint", "cpm", "CptNonPar", "ecp", "fpop",
     "InspectChangepoint", "jointseg", "mcp", "mosum", "not", "Rbeast",
     "segmented", "stepR", "strucchange", "VARDetect", "wbs"
   )
@@ -305,14 +305,14 @@ fpop::Fpop(mean_data_1, nrow(mean_data_1))$t.est
 ```
 
 ```{r univariate-mean-change-gfpop}
-gfpop::gfpop(
-  data = mean_data_1,
-  mygraph = gfpop::graph(
-    penalty = 2 * log(nrow(mean_data_1)) * gfpop::sdDiff(mean_data_1) ^ 2,
-    type = "updown"
-  ),
-  type = "mean"
-)$changepoints
+# gfpop::gfpop(
+#   data = mean_data_1,
+#   mygraph = gfpop::graph(
+#     penalty = 2 * log(nrow(mean_data_1)) * gfpop::sdDiff(mean_data_1) ^ 2,
+#     type = "updown"
+#   ),
+#   type = "mean"
+# )$changepoints
 ```
 
 ```{r univariate-mean-change-InspectChangepoint}
@@ -689,14 +689,14 @@ result <- list(
   wbs = wbs::wbs(well_log)$cpt$cpt.ic$mbic.penalty,
   mosum = mosum::mosum(c(well_log), G = 40)$cpts.info$cpts,
   # fpop = fpop::Fpop(well_log, length(well_log))$t.est,  # meaningless
-  gfpop = gfpop::gfpop(
-    data = well_log,
-    mygraph = gfpop::graph(
-      penalty = 2 * log(length(well_log)) * gfpop::sdDiff(well_log) ^ 2,
-      type = "updown"
-    ),
-    type = "mean"
-  )$changepoints,
+  # gfpop = gfpop::gfpop(
+  #   data = well_log,
+  #   mygraph = gfpop::graph(
+  #     penalty = 2 * log(length(well_log)) * gfpop::sdDiff(well_log) ^ 2,
+  #     type = "updown"
+  #   ),
+  #   type = "mean"
+  # )$changepoints,
   InspectChangepoint = InspectChangepoint::inspect(
     well_log,
     threshold = InspectChangepoint::compute.threshold(length(well_log), 1)
@@ -789,14 +789,14 @@ microbenchmark_result <- microbenchmark::microbenchmark(
   wbs = wbs::wbs(well_log),
   mosum = mosum::mosum(c(well_log), G = 40),
   fpop = fpop::Fpop(well_log, nrow(well_log)),
-  gfpop = gfpop::gfpop(
-    data = well_log,
-    mygraph = gfpop::graph(
-      penalty = 2 * log(length(well_log)) * gfpop::sdDiff(well_log) ^ 2,
-      type = "updown"
-    ),
-    type = "mean"
-  ),
+  # gfpop = gfpop::gfpop(
+  #   data = well_log,
+  #   mygraph = gfpop::graph(
+  #     penalty = 2 * log(length(well_log)) * gfpop::sdDiff(well_log) ^ 2,
+  #     type = "updown"
+  #   ),
+  #   type = "mean"
+  # ),
   InspectChangepoint = InspectChangepoint::inspect(
     well_log,
     threshold = InspectChangepoint::compute.threshold(length(well_log), 1)