36 support disabling toolchain cmake option #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the toolchain file is always passed as an option to cmake/ccmake It can be explicitly disabled setting the environment variable DOCKCROSS_PASS_CMAKE_TOOLCHAIN_FILE to 0
…e option Also revert the changes to ccmake.sh, the restriction doesn't apply to it. Suggested-by: Matt McCormick <matt.mccormick@kitware.com>
jcfr
force-pushed
the
36-support-disabling-toolchain-cmake-option
branch
from
c82df62
to
4876f14
Compare
|
Et voila, a more elegant way has been implemented. @thewtex PTAL |
thewtex
approved these changes
Sep 22, 2016
|
Perfect. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.