network inspect tests failing on docker master branch

[nishanttotla]

I just noticed this on a couple of PRs -- network inspect tests seem to be failing, only on docker master.

[allencloud]

That is true.

[allencloud]

@nishanttotla
I have got the root cause, when docker network inpsect xxx against swarm with docker/master, the out put has additional Engine details.

root@10-11-17-53:~# docker network inspect c8531ebcb827
[
    {
        "Name": "bridge",
        "Id": "c8531ebcb827ac1bb511c623c7e4c9bef2af4e69c78aaa5b910aaf3b3bfa4060",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": null,
            "Config": [
                {
                    "Subnet": "172.17.0.0/16",
                    "Gateway": "172.17.0.1"
                }
            ]
        },
        "Internal": false,
        "Containers": {},
        "Options": {
            "com.docker.network.bridge.default_bridge": "true",
            "com.docker.network.bridge.enable_icc": "true",
            "com.docker.network.bridge.enable_ip_masquerade": "true",
            "com.docker.network.bridge.host_binding_ipv4": "0.0.0.0",
            "com.docker.network.bridge.name": "docker0",
            "com.docker.network.driver.mtu": "1500"
        },
        "Labels": {},
        "Engine": {
            "ID": "6JZY:VVO3:734Q:UATB:QV7V:SLAF:7DHJ:7SA6:HHRD:3UZQ:VYK4:TQX7",
            "IP": "10.11.17.53",
            "Addr": "10.11.17.53:2376",
            "Name": "10-11-17-53",
            "Cpus": 1,
            "Memory": 2099249152,
            "Labels": {
                "a": "b",
                "executiondriver": "",
                "kernelversion": "3.13.0-63-generic",
                "operatingsystem": "Ubuntu 14.04.3 LTS",
                "storagedriver": "aufs"
            },
            "Version": "1.12.0-dev"
        }
    }
]

[allencloud]

#dibs

[allencloud]

It is because all docker cli refactored by github.com/spf13/cobra, while not take this into consideration in the docker client side.

[allencloud]

@nishanttotla
#2275 has fixed this. The master in the CI succeeds.
In addition, docker/master's dealing the network inspect in CLI are not so strictly as before. Needs more exploration.

[dongluochen]

Good finding. The current Network struct has an Engine field and I'm wondering why it is there.

[nishanttotla]

@allencloud great, thanks a lot! Looking at your PR now.