Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

remove engine details in volume and network api #2275

Conversation

allencloud
Copy link
Contributor

@allencloud allencloud commented May 25, 2016

remove engine details in volume and network api, like

GET /networks/{networkid:.*}
GET /volumes/{volumename:.*}

Fixed #2274
Fixed #2349

Signed-off-by: allencloud allen.sun@daocloud.io

Signed-off-by: allencloud <allen.sun@daocloud.io>
@dongluochen
Copy link
Contributor

LGTM.

The current Network struct has an attribute of Engine. I'm not sure why we need it.

@nishanttotla nishanttotla added this to the 1.2.4 milestone Jun 30, 2016
@nishanttotla
Copy link
Contributor

LGTM

I'm not sure why we need it either. I'm going to merge this PR since it fixes our CI.

cc @mavenugo for more insight on this.

@nishanttotla nishanttotla merged commit da0cb17 into docker-archive:master Jun 30, 2016
@allencloud allencloud deleted the remove-engine-details-in-volume-network-API branch July 1, 2016 02:23
ChristianKniep pushed a commit to ChristianKniep/swarm that referenced this pull request Jul 27, 2017
…details-in-volume-network-API

remove engine details in volume and network api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants