This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
TLS support. #160
Merged
TLS support. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Works here. LGTM |
|
|
||
| flTlsCaCert := cli.StringFlag{ | ||
| Name: "tlscacert", | ||
| Value: "/root/.docker/ca.pem", |
There was a problem hiding this comment.
I think you should change /root/ -> $HOME
There was a problem hiding this comment.
In my implementation I opted to not put a default value since this isn't really client code.
TLS authentication support between the CLI and Swarm but also between Swarm and the Docker nodes. Closes docker-archive#148. Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
|
Removed default values. PTAL /cc @vieux |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS authentication support between the CLI and Swarm but also between
Swarm and the Docker nodes.
Closes #148
Signed-off-by: Andrea Luzzardi aluzzardi@gmail.com