This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Updating info function to use engine-api #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
info-engine-api
branch
from
675d58b
to
6af37c4
Compare
| @@ -187,15 +186,14 @@ func TestLoadImage(t *testing.T) { | |||
| // create mock client | |||
| client := mockclient.NewMockClient() | |||
| apiClient := engineapimock.NewMockClient() | |||
| client.On("Info").Return(mockInfo, nil) | |||
| apiClient.On("Info").Return(mockInfo, nil) | |||
| apiClient.On("ServerVersion").Return(mockVersion, nil) | |||
There was a problem hiding this comment.
why did you have to move ServerVersion up in every tests ?
There was a problem hiding this comment.
For cosmetic reasons mostly. Last time I put it separately, away from all the client.On(...).Return(...) calls, but it makes sense to have everything together. No change in functionality.
10 tasks
|
ping @dongluochen
|
|
LGTM |
1 similar comment
|
LGTM |
vieux
added a commit
that referenced
this pull request
Mar 9, 2016
Updating info function to use engine-api
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
Updating info function to use engine-api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves over the
Info()function call over to useengine-api, along with corresponding tests. Some mismatch betweenintandint64values needed to be adjusted.This is part of #1879.
Signed-off-by: Nishant Totla nishanttotla@gmail.com