This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Moving Image handling to engine-api #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
changed the title
10 tasks
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
|
Ping @vieux @dongluochen @abronan (only the leader election tests are failing) |
|
Thanks to @dongluochen, we figured out that this PR actually fixes a race condition that's been causing issues in #1983. |
|
@nishanttotla leader election tests are fixed with #2050 so this should be good. (only affects rescheduling though so @vieux should confirm) |
|
LGTM |
1 similar comment
|
LGTM |
|
That's amazing. Switching to engine-api actually fixes a bug? Great! |
|
@MHBauer a bug that likely came in because we have two clients, so ¯_(ツ)_/¯ That said, turns out we were wrong earlier. The bug is not really a race condition, but an improper use of the |
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
…ngine-api Moving Image handling to engine-api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves over all image handling to
engine-api. It's self-contained, and relatively small.It's part of implementing the proposal #1879.