This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Collapse watch and update commands into commit
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bill Farner <bill@docker.com>
Current coverage is 69.50% (diff: 73.50%)@@ master #293 diff @@
==========================================
Files 25 25
Lines 1368 1302 -66
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 961 905 -56
+ Misses 327 320 -7
+ Partials 80 77 -3
|
Signed-off-by: Bill Farner <bill@docker.com>
chungers
reviewed
Nov 14, 2016
|
|
||
| func (m *manager) doUnwatchGroups(config GlobalSpec) error { | ||
| log.Infoln("Unwatching groups") | ||
| func (m *manager) doReleaseGroups(config GlobalSpec) error { |
There was a problem hiding this comment.
Just call this doFreeGroups to be consistent with the plugin free verb?
There was a problem hiding this comment.
Thanks, this one slipped past my grepping.
chungers
approved these changes
Nov 14, 2016
Signed-off-by: Bill Farner <bill@docker.com>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
* Added changes to support new Moby AMI build process Signed-off-by: Ken Cochrane <KenCochrane@gmail.com> * Fixed some bugs in nightly and building CS AMI Signed-off-by: Ken Cochrane <kencochrane@gmail.com> * Changed DDC manager test stack instance from m3.medium to t2.medium, since it wasn't available in all regions Signed-off-by: Ken Cochrane <kencochrane@gmail.com> * Fixed comments from PR related to HASH and NOW Signed-off-by: Ken Cochrane <kencochrane@gmail.com> * Added git pull before we build to make sure we have latest moby Signed-off-by: Ken Cochrane <kencochrane@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
commitcommand, with a--pretendflagunwatchis renamed tofreeThe following commands are removed:
watch,update,stop-update, anddescribe-updateCloses #292
Signed-off-by: Bill Farner bill@docker.com