Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

JSON-RPC 2.0 compliance #310

Merged
merged 11 commits into from Nov 29, 2016
Merged

JSON-RPC 2.0 compliance #310

merged 11 commits into from Nov 29, 2016

Conversation

chungers
Copy link
Contributor

This small PR switches the Codec from an outdated JSON-RPC 1.0 implementation to the latest 2.0 spec implementation.

This impacts those who want to develop plugins using a different language / tooling for JSON-RPC. A short summary of over the wire representation can be found here: https://en.wikipedia.org/wiki/JSON-RPC#Version_2.0

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "json-rpc2" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354236520
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Copy link
Contributor

@wfarner wfarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the PR checks pass. Thanks for investigating this!

@chungers chungers merged commit a6d51a5 into docker-archive:master Nov 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants