Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Add a Type field to Attachments #316

Merged
merged 2 commits into from Dec 2, 2016

Conversation

wfarner
Copy link
Contributor

@wfarner wfarner commented Dec 1, 2016

Closes #312

Signed-off-by: Bill Farner bill@docker.com

Signed-off-by: Bill Farner <bill@docker.com>
@codecov-io
Copy link

Current coverage is 68.89% (diff: 73.68%)

Merging #316 into master will decrease coverage by 0.01%

@@             master       #316   diff @@
==========================================
  Files            27         27          
  Lines          1441       1453    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            993       1001     +8   
- Misses          356        359     +3   
- Partials         92         93     +1   

Powered by Codecov. Last update 6ff1e3a...c10494a

@chungers
Copy link
Contributor

chungers commented Dec 1, 2016

You beat me to it!! Thanks for this PR!

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "attachment-type" git@github.com:wfarner/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354030992
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Copy link
Contributor

@chungers chungers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wfarner wfarner merged commit a1e94af into docker-archive:master Dec 2, 2016
@wfarner wfarner deleted the attachment-type branch December 2, 2016 19:02
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants